Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix update_vocab for LM #2056

Merged
merged 2 commits into from
Apr 30, 2021
Merged

Fix update_vocab for LM #2056

merged 2 commits into from
Apr 30, 2021

Conversation

funboarder13920
Copy link
Collaborator

@funboarder13920 funboarder13920 commented Apr 30, 2021 •
edited
Loading

Encoder fields do not exist for language models. A check must be performed before deleting or updating those fields.

francoishernandez
francoishernandez approved these changes Apr 30, 2021
View reviewed changes
Copy link
Member

@francoishernandez francoishernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@francoishernandez francoishernandez merged commit 2b8a173 into OpenNMT:master Apr 30, 2021
@funboarder13920 funboarder13920 deleted the fix_update_vocab_LM branch April 30, 2021 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francoishernandez francoishernandez francoishernandez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@funboarder13920 @francoishernandez