Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Source Word Features in Translation #1564

Closed
wants to merge 4 commits into from

Conversation

vikrant97
Copy link

@vikrant97 vikrant97 commented Sep 16, 2019

This PR addresses the issue of different feature vector sizes for different word level features (#1534 ).
Now the user can pass a list of "feat_vec_size" so as to use these feature dimensions for word level features. This feature is missing in OpenNMT-py.

@vince62s
Copy link
Member

Hi @vikrant97 where do you stand on target features, are you still willing ot work on it ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants