Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backward compatibility for the Wav2Vec2 ASR model #1810

Merged
merged 8 commits into from
Nov 5, 2024

Conversation

homink
Copy link
Contributor

@homink homink commented Oct 28, 2024

This repo supports backward compatibility for Wav2Vec2 ASR conversion models prior to v4.4.0, as PR #1758 introduces a new type of Wav2Vec2 ASR model conversion

@homink
Copy link
Contributor Author

homink commented Oct 29, 2024

@minhthuc2502 any ideas how to avoid the downloading error from NVIDIA?

@homink homink changed the title Backward compatiability for the Wav2Vec2 ASR model Backward compatibility for the Wav2Vec2 ASR model Oct 30, 2024
@homink
Copy link
Contributor Author

homink commented Oct 30, 2024

@minhthuc2502 It turned out the error was due to a missing header file. I’m looking forward to the next release, hopefully with this PR included!

@homink
Copy link
Contributor Author

homink commented Nov 4, 2024

@minhthuc2502 Could you please have a look and merge it?

@minhthuc2502
Copy link
Collaborator

Look good to me. Thank you for your PR.

@minhthuc2502 minhthuc2502 merged commit 5795843 into OpenNMT:master Nov 5, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants