Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving from Pipenv to Poetry #277

Closed
chinmayshah99 opened this issue Aug 28, 2020 · 3 comments
Closed

Moving from Pipenv to Poetry #277

chinmayshah99 opened this issue Aug 28, 2020 · 3 comments
Labels
Hacktoberfest Open for hacktoberfest 2020 Priority: 4 - Low 😎 Should only be scheduled if it's important relative to other issues Type: Discussion 🔈 When further discussion and debate is required Type: Improvement 📈 Performance improvement not introducing a new feature or requiring a major refactor

Comments

@chinmayshah99
Copy link
Member

Description

Poetry is a much better package manager compared to pipenv, with similarity to package manager in rust & npm. We could migrate. Open to discussions.

Additional Context

Poetry: https://python-poetry.org/
@chinmayshah99 chinmayshah99 added Type: Improvement 📈 Performance improvement not introducing a new feature or requiring a major refactor Priority: 4 - Low 😎 Should only be scheduled if it's important relative to other issues Type: Discussion 🔈 When further discussion and debate is required labels Aug 28, 2020
@alejandrosame
Copy link
Member

I'm ok with making a test branch with Poetry tooling to see if it works better for us. Pipenv certainly isn't up to what they promise (yet), it gets too much in the way for little gain.

I don't discard either falling back to plain venv and simply providing targets/actions with our Makefile.

@chinmayshah99
Copy link
Member Author

chinmayshah99 commented Aug 28, 2020 via email

@alejandrosame alejandrosame mentioned this issue Sep 13, 2020
Closed
2 tasks
@chinmayshah99 chinmayshah99 added the Hacktoberfest Open for hacktoberfest 2020 label Oct 1, 2020
@alejandrosame
Copy link
Member

@BrendanSchell will work on this

@BrendanSchell BrendanSchell mentioned this issue Oct 12, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Hacktoberfest Open for hacktoberfest 2020 Priority: 4 - Low 😎 Should only be scheduled if it's important relative to other issues Type: Discussion 🔈 When further discussion and debate is required Type: Improvement 📈 Performance improvement not introducing a new feature or requiring a major refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alejandrosame @chinmayshah99