Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arm: Declare symbols as .type function #4998

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Dec 3, 2024

While revising the vcpkg port, I ran into this error pattern when building a test project for arm-neon-android (NDK r27c, static linkage) during a find_package(BLAS) in CMake:

ld.lld: error: /vcpkg/installed/arm-neon-android/debug/lib/libopenblas.a(sgemm_nn.c.o):(function sgemm_nn: .text.sgemm_nn+0x232): branch and link relocation: R_ARM_THM_CALL to non STT_FUNC symbol: sgemm_otcopy interworking not performed; consider using directive '.type sgemm_otcopy, %function' to give symbol type STT_FUNC if interworking between ARM and Thumb is required; level3.c:332 (/vcpkg/buildtrees/openblas/src/v0.3.28-a14d95ad12.clean/driver/level3/level3.c:332)

The solution is adapted from common_arm64.h etc.

@martin-frbg
Copy link
Collaborator

Thanks - I'm not sure if there are (still) any real-world applications of iOS on ARMv6, but it certainly doesn't hurt to support them.

@martin-frbg martin-frbg added this to the 0.3.29 milestone Dec 4, 2024
@martin-frbg martin-frbg merged commit 5f65846 into OpenMathLib:develop Dec 4, 2024
81 of 83 checks passed
@dg0yt dg0yt deleted the arm-type-function branch December 5, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants