-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP,Testing]: Add test for mips64 #3769
Conversation
Thanks. Failures seen here are somewhat suspicious - in particular in the MIPS64_GENERIC build that uses only C kernels. |
My pleasure. It was the accuracy that caused the failure when target is I6400, I6500 and P6600. They all use |
Yes the DSDOT is somewhat familiar - this used to be a problem in almost all architectures until a few years ago. I thought I had fixed them all back then, but maybe I did not touch the MSA kernel as I had no hardware to test. |
Thanks again (I wonder if the extending of individual values to double precision is necessary, or if a simple (double) cast of the multiplication would suffice to avoid truncation of the intermediate result ?). Will "fix" MIPS64_GENERIC next (missing KERNEL file leading to wrong DGEMM kernel getting built), then see if I can do away with MIPS64_GENERIC again as we already have GENERIC. |
My pleasure. From my point of view, since SIMD instructions are used in the implementation, a simple (double) cast of the multiplication is not useful.
Test on my i5-6600T X86_64 machine, the utest dsdot:dsdot_n_1 failed.
When |
Try to add mips64 test.