Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stack overflow bug in getrf_parallel #246

Closed
xianyi opened this issue Jul 7, 2013 · 0 comments
Closed

stack overflow bug in getrf_parallel #246

xianyi opened this issue Jul 7, 2013 · 0 comments
Assignees
@xianyi
Labels
Bug
Milestone
0.2.7

Comments

@xianyi
Copy link
Collaborator

xianyi commented Jul 7, 2013

This bug is track JuliaLang/julia#3630

When NUM_THREADS is very large, e.g. 128 or 256, it causes the stack overflowing in getrf_parallel.

There is a similar bug in potrf_parallel.
@ghost ghost assigned xianyi Jul 7, 2013
xianyi added a commit that referenced this issue Jul 7, 2013
@xianyi
Refs #221 #246. Fixed the overflowing stack bug in mutlithreading BLAS3.
5d33121 
When NUM_THREADS(MAX_CPU_NUNBERS) is very large ,e.g. 256.

typedef struct {
  volatile BLASLONG working[MAX_CPU_NUMBER][CACHE_LINE_SIZE * DIVIDE_RATE];
} job_t;

job_t          job[MAX_CPU_NUMBER];

The job array is equal 8MB.

Thus, We use malloc instead of stack allocation.
@xianyi xianyi closed this as completed Jul 7, 2013
@ViralBShah ViralBShah mentioned this issue Jul 7, 2013
Closed
xianyi added a commit that referenced this issue Jul 10, 2013
@xianyi
Refs #214, #221, #246. Fixed the getrf overflow bug on Windows.
32d2ca3 
I used a smaller threshold since the stack size is 1MB on windows.
@xianyi xianyi mentioned this issue Jan 26, 2016
Merged
@pmkc pmkc mentioned this issue Feb 4, 2017
Closed
@pelson pelson mentioned this issue Jan 6, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xianyi xianyi

Labels
Bug
Projects
None yet
Milestone
0.2.7
Development

No branches or pull requests
1 participant
@xianyi