Return total file size for Content-Range instead of * #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the client loads a file range using the range header, webdav-server returns correct data with the Content-Range response header.
Before:
Content-Range: 0-1024/*The asterisk (*) is allowed according to http specs instead of returning the total file size. But some clients (like the pdftools.com PDF Web Viewer) require the real file size to work. This pr changes the behavior to return the file size like:
Now:
Content-Range: 0-1024/4000I've also needed to change some stuff for TypeScript to work.