Cleaned the code

OpenMarshal · Jul 10, 2017 · 50782df · 50782df
1 parent 03105d9
commit 50782df
Show file tree

Hide file tree

Showing 8 changed files with 13 additions and 20 deletions.
diff --git a/examples/v2/customMethod/index.ts b/examples/v2/customMethod/index.ts
@@ -11,7 +11,7 @@ server.method('TRACE', {
         const nbPaths = wctx.requested.path.paths.length;
         const method = wctx.headers.find('trace-method', '*').toLowerCase();
         const separator = wctx.headers.find('trace-separator', '\r\n');
-        const iDepth = parseInt(wctx.headers.find('trace-depth', 'infinity').toLowerCase());
+        const iDepth = parseInt(wctx.headers.find('trace-depth', 'infinity').toLowerCase(), 10);
         const depth = isNaN(iDepth) ? -1 : iDepth;
         wctx.setCode(webdav.HTTPCodes.OK);
 

diff --git a/src/server/commands/Propfind.ts b/src/server/commands/Propfind.ts
@@ -248,9 +248,9 @@ export function method(arg : MethodCallArgs, callback)
                                 const prop = propstatError.ele('D:prop');
                                 propstatError.ele('D:status').add(propstatStatus(HTTPCodes.NotFound));
 
-                                for(let i = 0; i < reqBody.leftElements.length; ++i)
-                                    if(reqBody.leftElements[i])
-                                        prop.ele(reqBody.leftElements[i].name);
+                                for(const el of reqBody.leftElements)
+                                    if(el)
+                                        prop.ele(el.name);
                             }
                             callback();
                         }

diff --git a/src/server/commands/Proppatch.ts b/src/server/commands/Proppatch.ts
@@ -65,7 +65,7 @@ export function method(arg : MethodCallArgs, callback)
                                         arg.invokeEvent(eventName, r, el)
                                     notify(el, e)
                                 })
-                                .done(() => finalize())
+                                .done((_) => finalize())
                         })
                     }
 

diff --git a/src/server/v2/commands/Propfind.ts b/src/server/v2/commands/Propfind.ts
@@ -274,9 +274,9 @@ export default class implements HTTPMethod
                                     const prop = propstatError.ele('D:prop');
                                     propstatError.ele('D:status').add(propstatStatus(HTTPCodes.NotFound));
 
-                                    for(let i = 0; i < reqBody.leftElements.length; ++i)
-                                        if(reqBody.leftElements[i])
-                                            prop.ele(reqBody.leftElements[i].name);
+                                    for(const el of reqBody.leftElements)
+                                        if(el)
+                                            prop.ele(el.name);
                                 }
                                 callback();
                             }

diff --git a/src/server/v2/commands/Proppatch.ts b/src/server/v2/commands/Proppatch.ts
@@ -100,7 +100,7 @@ export default class implements HTTPMethod
                                         if(el.type === 'element')
                                             notify(el, e)
                                     })
-                                    .done(() => finalize())
+                                    .done((_) => finalize())
                             })
                         }
 

diff --git a/src/server/v2/commands/Unlock.ts b/src/server/v2/commands/Unlock.ts
@@ -98,4 +98,4 @@ export default class implements HTTPMethod
     {
         return !!type;
     }
-}
+}
diff --git a/src/server/v2/webDAVServer/BeforeAfter.ts b/src/server/v2/webDAVServer/BeforeAfter.ts
@@ -1,9 +1,6 @@
 import { HTTPRequestContext, HTTPMethod } from '../WebDAVRequest'
 
-export interface RequestListener
-{
-    (ctx : HTTPRequestContext, next : () => void) : void
-}
+export type RequestListener = (ctx : HTTPRequestContext, next : () => void) => void;
 
 function invokeBARequest(collection : RequestListener[], base : HTTPRequestContext, callback)
 {
@@ -40,4 +37,4 @@ export function invokeBeforeRequest(base : HTTPRequestContext, callback)
 export function invokeAfterRequest(base : HTTPRequestContext, callback)
 {
     invokeBARequest(this.afterManagers, base, callback);
-}
+}
diff --git a/src/server/v2/webDAVServer/WebDAVServer.ts b/src/server/v2/webDAVServer/WebDAVServer.ts
@@ -1,5 +1,5 @@
-import { WebDAVServerOptions, setDefaultServerOptions } from '../WebDAVServerOptions'
 import { HTTPRequestContext, ExternalRequestContext, RequestContextExternalOptions, RequestContext } from '../RequestContext'
+import { WebDAVServerOptions, setDefaultServerOptions } from '../WebDAVServerOptions'
 import { HTTPCodes, HTTPMethod } from '../WebDAVRequest'
 import { HTTPAuthentication } from '../../../user/v2/authentication/HTTPAuthentication'
 import { PrivilegeManager } from '../../../user/v2/privilege/PrivilegeManager'
@@ -241,10 +241,6 @@ export class WebDAVServer
         };
     }
 
-
-
-
-
     onUnknownMethod(unknownMethod : HTTPMethod)
     {
         this.unknownMethod = unknownMethod;
-Original file line number
+Diff line change
@@ Expand Up / @@ -98,4 +98,4 @@ export default class implements HTTPMethod @@
         {
             return !!type;
         }
-    }
+    }