PhpStan: some fixes #4363
Open
PhpStan: some fixes #4363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: PayPal
|
what does "k/t" mean? |
sreichel
commented
Nov 18, 2024
Comment on lines
+2154
to
2156
| message: "#^Parameter \\#8 \\$productId of method Mage_Catalog_Model_Product_Type_Price\\:\\:calculatePrice\\(\\) expects int\\|null, array given\\.$#" | ||
| count: 1 | ||
| path: app/code/core/Mage/CatalogIndex/Model/Data/Abstract.php |
There was a problem hiding this comment.
Possible bug. Check later.
kiatng
reviewed
Nov 25, 2024
kiatng
previously approved these changes
Nov 26, 2024
# Conflicts: # .phpstan.dist.baseline.neon # app/code/core/Mage/Payment/Model/Method/Abstract.php # app/code/core/Mage/Sales/Model/Order/Payment.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed some error.