Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PhpStan L5 fixes for Mage/Admin #2761

Merged
merged 2 commits into from
Nov 30, 2022
Merged

PhpStan L5 fixes for Mage/Admin #2761

merged 2 commits into from
Nov 30, 2022

Conversation

sreichel
Copy link
Contributor

Description (*)

Related Pull Requests

  1. See Phpstan: workflow update #2707

Manual testing scenarios (*)

  1. phpstan app/code/core/Mage/Admin/Model/ -l 5

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added Component: AdminNotification Relates to Mage_AdminNotification Component: Admin Relates to Mage_Admin Component: Core Relates to Mage_Core Component: lib/Varien Relates to lib/Varien Component: lib/* Relates to lib/* Component: Log Relates to Mage_Log Mage.php Relates to app/Mage.php labels Nov 25, 2022
fballiano
fballiano previously approved these changes Nov 27, 2022
View reviewed changes
kiatng
kiatng previously approved these changes Nov 29, 2022
View reviewed changes
@sreichel sreichel merged commit 5e04bdb into OpenMage:1.9.4.x Nov 30, 2022
@sreichel sreichel deleted the phpstan-daily-l5-admin branch November 30, 2022 02:01
@github-actions
Copy link
Contributor

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  5 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 5e04bdb. ± Comparison against base commit 7fe65ad.

@fballiano fballiano mentioned this pull request Dec 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiatng kiatng kiatng approved these changes

@fballiano fballiano fballiano approved these changes

Assignees
No one assigned
Labels
Component: Admin Relates to Mage_Admin Component: AdminNotification Relates to Mage_AdminNotification Component: Core Relates to Mage_Core Component: lib/Varien Relates to lib/Varien Component: lib/* Relates to lib/* Component: Log Relates to Mage_Log environment Mage.php Relates to app/Mage.php phpstan
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sreichel @fballiano @kiatng