Fix mod_php8 wrong notation in .htaccess files

[fballiano]

Lately "mod_php8" instructions were added to some htaccess but they don't work, the right notation is mod_php:
nextcloud/server#26569

I also did a bit of reformatting, hope you like it.

Note: the diff looks complicated (dunno why) but if you check the 2 files:

• https://github.com/fballiano/openmage/blob/fix_modphp8_wrong_notation/skin/.htaccess
• https://github.com/fballiano/openmage/blob/fix_modphp8_wrong_notation/media/.htaccess

you'll see they're pretty straightforward

Manual testing scenarios (*)

Enable apache's mod_php for php8 and test some php_value directives present in htaccess files, they won't work now, they work after this patch.

[addison74]

This file /js/.htaccess in branch 20.0 needs to be changed as well.

When I did PRs to modify these 3 files I specified that the comment mode is similar to the Magento team. At that time you suggested another way and I took part of the idea. Now I see that you are imposing what you proposed then. Personally I would only delete the number 8. If you go on this format you will have to change all the other files, including the root one, at least to have a good note on the artistic impression.

[fballiano]

Since this PR targets v19 I can't change a v20 file...

Imposing?? I'm not imposing anything! I politely asked a thousand changes to your PRs that you mostly ignore and then I end up accepting it since I actually try to mediate.
But I still think that the notation that's now on the repo has zero readability since it's doesn't have indentation nor a correct divisions in sections so I'm committing what I think it's right. Or do I have to do what you want? Mediation goes both ways.

Also, I never liked the way you broke a lot of translation packages, they are important to me. But I still accepted that that's your way to go. But I won't accept to be told that I "impose" stuff.

[fballiano]

BTW I still don't like this:

but I kept it anyway.

[addison74]

I used the word "impose" for a specific purpose. I know you've had an issue with me for a while and I appreciate you saying it publicly. For your information I did not brake "a lot of translation packages". If I had broken something my PRs would not have been approved. If I remember correctly when I requested a change in the ProductAlert controller you came with the change only of the CSV files. I respected the decision of the majority, your opinion was accepted and I closed the PR and you created another one. As a programmer I look in that code and see the logical fracture but that is, we choose to add new strings that require translations but we do not fix the programming error.

In several replies you had a not exactly appropriate way of addressing, but due to your interest in this project and notable contribution I overlooked it. I am a person who has worked in teams for a long time and I think that a little respect is not too much to ask. I will talk to Daniel to revoke my status as a collaborator because it is obvious that we have personal issues and I choose to detach myself from them. I had made the decision for some time after another reply from you, but inexplicably I postponed it until today. Thank you.

[fballiano]

All of the translation packages get broken every time a "defining" string (the first one in the CSV) is changes, that is a fact.

I accepted your point of view on things (you've around 30 merged PRs and I'm pretty sure I approved and merged 90% of those) that I didn't like because it's a team effort, but that goes both ways. If I say something about those (like that I don't like the "Don't permit" wording) it's because I care about the project (and I got ignored many times, and approved anyways).

If I said something that offended you I apologise, maybe the lack of time or not being english mother tongue didn't help me. But I feel you constantly reject my notes when I'm supposed to constantly accept yours.

[addison74]

I don't remember forcing you in any way to approve my PRs. If you did it against your own conviction it wasn't good at all, both for me and for others. In any case, it is good that each party has expressed its point of view so that there are no interpretations from the others. One thing you can be sure of from now on, you will never need to approve any PR created by me. You got rid of this burden. Further success in the team's efforts, I hope that in the future there will be no more such situations.

[fballiano]

wow... ok