Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make from_dict backwards compatible in Python client. #3226

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

JDarDagran
Copy link
Contributor

Problem

1.24.0 release introduced backwards-incompatible change in from_dict method of Python client.

Solution

Bring back from_dict to expect transport section extracted only and deprecate the method in favor of config argument.

Checklist

  • You've signed-off your work
  • Your pull request title follows our guidelines
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • Your comment includes a one-liner for the changelog about the specific purpose of the change (not required for changes to tests, docs, or CI config)
  • You've versioned the core OpenLineage model or facets according to SchemaVer (if relevant)
  • You've added a header to source files (if relevant)

SPDX-License-Identifier: Apache-2.0
Copyright 2018-2024 contributors to the OpenLineage project

@JDarDagran JDarDagran requested a review from a team as a code owner November 6, 2024 10:59
@boring-cyborg boring-cyborg bot added area:client/python openlineage-python area:tests Testing code language:python Uses Python programming language labels Nov 6, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.73%. Comparing base (159e571) to head (c5d00a1).
Report is 6 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3226   +/-   ##
=======================================
  Coverage   85.73%   85.73%           
=======================================
  Files          54       54           
  Lines        3119     3119           
=======================================
  Hits         2674     2674           
  Misses        445      445           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mobuchowski mobuchowski merged commit 8906ff3 into main Nov 6, 2024
42 checks passed
@mobuchowski mobuchowski deleted the python/make-from-dict-backwards-compatible branch November 6, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:client/python openlineage-python area:tests Testing code language:python Uses Python programming language
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants