Handle characters in the parser. #45
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means I can do things like 'a', 'b', 'c' Also fix my misunderstanding of js regexs. This didn't cause a bug because we match the entire line anyway.
|
|
||
| var char_match = token.match(/^'(.)'$/); | ||
| if (char_match) { | ||
| binary_data.push(char_match[1].charCodeAt()); |
There was a problem hiding this comment.
shouldn't this be
binary_data.push(char_match[1].charCodeAt(0));There was a problem hiding this comment.
Apparently 0 is the default.
I think I'm going to re-write the parser anyway.
|
LGTM, aside from a comment |
|
Cool, I hit this stumbling block too. |
| @@ -340,20 +340,26 @@ angular.module('rdmApp', []) | |||
| var token = tokens[j]; | |||
| var hex_suffix_match = token.match(/^([\da-fA-F]{1,2})h$/); | |||
| if (hex_suffix_match) { | |||
| binary_data.push(parseInt(hex_suffix_match[0], 16)); | |||
There was a problem hiding this comment.
Can we have a comment at the top of this block reminding people of the broken way capture groups work in JS (it gets even messier if it's a global match with groups!
|
Only one comment from me. |
peternewman
reviewed
Jul 1, 2017
| application: "olp-rdm-staging" | ||
| #application: "rdmprotocol-hrd" | ||
| #application: "olp-rdm-staging" | ||
| application: "rdmprotocol-hrd" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means I can do things like
'a', 'b', 'c'
Also fix my misunderstanding of js regexs. This didn't cause a bug because we
match the entire line anyway.