-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build Java libs via Travis #702
Conversation
This reverts commit c6525cd.
configure.ac
Outdated
@@ -763,6 +763,7 @@ Python API: ${enable_python_libs} | |||
Java API: ${enable_java_libs} | |||
Enable HTTP Server: ${have_microhttpd} | |||
RDM Responder Tests: ${enable_rdm_tests} | |||
Ja Rule: ${BUILD_JA_RULE} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this actually works currently. If we want it to show the final state (including libusb status), I may need to have a rethink.
This looks fine to me. Any reason why we shouldn't submit? |
Just the rather comical thing that it doesn't run the Java tests: |
Which probably explains why they weren't running when they were added in via Maven!
Well I think I've answered this question. @nomis52 excluded the only test here cd10e88#diff-61657881d138c2b7ac1366d88c9ee035R24 which is why it's not running any. I think this actually makes sense as so far all the Java tests require a running olad to talk to (which we don't normally expect). Indeed Travis confirms this. So we probably need to add a few tests of the ByteString stuff and call it a day for now: Then this can FINALLY be merged! |
This should allow us to run the tests except during CI. http://stackoverflow.com/questions/8304110/skip-a-submodule-during-a-maven-build |
… should work for both normal and VPATH/distcheck builds
This is ready for review now @nomis52 . I've tested it via a distcheck build and also a normal in path build and they both work and I've added some (fairly trivial) standalone Java tests, which hopefully others can expand on in future. |
Fix the resulting issues that appeared