Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Java libs via Travis #702

Merged
merged 63 commits into from
Apr 24, 2017
Merged

Conversation

peternewman
Copy link
Member

Fix the resulting issues that appeared

configure.ac Outdated
@@ -763,6 +763,7 @@ Python API: ${enable_python_libs}
Java API: ${enable_java_libs}
Enable HTTP Server: ${have_microhttpd}
RDM Responder Tests: ${enable_rdm_tests}
Ja Rule: ${BUILD_JA_RULE}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this actually works currently. If we want it to show the final state (including libusb status), I may need to have a rethink.

@peternewman peternewman changed the title Build RDM tests, Ja Rule and Java libs via Travis Build Java libs via Travis Apr 5, 2015
@nomis52
Copy link
Member

nomis52 commented Jan 2, 2016

This looks fine to me. Any reason why we shouldn't submit?

@peternewman
Copy link
Member Author

Just the rather comical thing that it doesn't run the Java tests:
https://travis-ci.org/OpenLightingProject/ola/jobs/87932624#L1400

Which probably explains why they weren't running when they were added in via Maven!
@peternewman
Copy link
Member Author

peternewman commented Apr 14, 2017

Well I think I've answered this question. @nomis52 excluded the only test here cd10e88#diff-61657881d138c2b7ac1366d88c9ee035R24 which is why it's not running any.

I think this actually makes sense as so far all the Java tests require a running olad to talk to (which we don't normally expect). Indeed Travis confirms this.

So we probably need to add a few tests of the ByteString stuff and call it a day for now:
https://github.com/OpenLightingProject/ola/blob/master/java/src/main/java/ola/OlaClient.java#L408

Then this can FINALLY be merged!

@peternewman
Copy link
Member Author

This should allow us to run the tests except during CI.

http://stackoverflow.com/questions/8304110/skip-a-submodule-during-a-maven-build

@peternewman
Copy link
Member Author

This is ready for review now @nomis52 . I've tested it via a distcheck build and also a normal in path build and they both work and I've added some (fairly trivial) standalone Java tests, which hopefully others can expand on in future.

@peternewman
Copy link
Member Author

I spoke slightly too soon @nomis52 . Are you happy with this tweak a1236cc making those functions static given they don't reference the protocol/client at all.

@peternewman peternewman merged commit c64198a into OpenLightingProject:master Apr 24, 2017
@peternewman peternewman added this to the 0.11.0 milestone Apr 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants