Archive screenshots in GHA #465
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -269,6 +270,39 @@ it('attach debugger for start with custom parameter event', async () => { | |||
|
|
|||
| }).timeout(350000); | |||
|
|
|||
There was a problem hiding this comment.
Please add a comment here explaining the purpose of this after hook and reason for adding after hook here.
There was a problem hiding this comment.
Added the comment.
src/test/MavenTestDevModeActions.ts
Outdated
| }); | ||
|
|
||
| function copyFolderContents(sourceFolder: string, destinationFolder: string): void { | ||
| console.log('source folder', sourceFolder); |
There was a problem hiding this comment.
Remove unneccessary logs.
|
|
||
| # Archive screenshots | ||
| - name: Archive screenshots | ||
| if: always() |
There was a problem hiding this comment.
This means screenshot will capture even if tests are success?
There was a problem hiding this comment.
It means that the screenshot will be captured even if the tests are failed. In GHA, the following steps after a failure are skipped. if always() ensures that the screenshots are archived even if the steps above are failing which means the screenshots will be archived even after a test failure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a new step in the workflow to archive screenshots.
Fixes #441