-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue#354 Test cases added for Gradle and Maven #364
base: main
Are you sure you want to change the base?
Issue#354 Test cases added for Gradle and Maven #364
Conversation
|
@aparnamichael |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!!
This will be merged after merging issue 337 PR. |
…hub.com/SuparnaSuresh/liberty-tools-vscode into issue354-GradleTestcaseProjectNameSpace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the test suite for dev actions was copied entirely for both maven and gradle to run against some different projects. If a change to a test is needed, we would need to make the change in multiple places. This will lead to difficult code management, especially if we continue to copy tests anytime we need to test against a different kind of project (think multi-module projects).
I believe the ultimate goal here is to run the existing dev actions tests against projects with spaces in the path. We should not copy the tests. We should find a way to run the same tests against various projects (i.e. find a way to parameterize the projects for the tests).
Fixes #354
Added test case to handling the scenario for