Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating guide’s content to use the Liberty AKS portal for creating cluster, resource group, and container #129

Merged
merged 75 commits into from
Feb 10, 2025

Conversation

Ruilin-Ma
Copy link
Contributor

@Ruilin-Ma Ruilin-Ma commented Jul 22, 2024

README.adoc Outdated Show resolved Hide resolved
README.adoc Outdated Show resolved Hide resolved
README.adoc Outdated Show resolved Hide resolved
README.adoc Outdated Show resolved Hide resolved
README.adoc Outdated Show resolved Hide resolved
Ruilin-Ma and others added 2 commits August 6, 2024 11:55
* Bump org.apache.maven.plugins:maven-failsafe-plugin in /start

Bumps [org.apache.maven.plugins:maven-failsafe-plugin](https://github.com/apache/maven-surefire) from 3.3.0 to 3.3.1.
- [Release notes](https://github.com/apache/maven-surefire/releases)
- [Commits](apache/maven-surefire@surefire-3.3.0...surefire-3.3.1)

---
updated-dependencies:
- dependency-name: org.apache.maven.plugins:maven-failsafe-plugin
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Bump org.apache.maven.plugins:maven-surefire-plugin in /start

Bumps [org.apache.maven.plugins:maven-surefire-plugin](https://github.com/apache/maven-surefire) from 3.3.0 to 3.3.1.
- [Release notes](https://github.com/apache/maven-surefire/releases)
- [Commits](apache/maven-surefire@surefire-3.3.0...surefire-3.3.1)

---
updated-dependencies:
- dependency-name: org.apache.maven.plugins:maven-surefire-plugin
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Bump org.apache.maven.plugins:maven-failsafe-plugin in /finish

Bumps [org.apache.maven.plugins:maven-failsafe-plugin](https://github.com/apache/maven-surefire) from 3.3.0 to 3.3.1.
- [Release notes](https://github.com/apache/maven-surefire/releases)
- [Commits](apache/maven-surefire@surefire-3.3.0...surefire-3.3.1)

---
updated-dependencies:
- dependency-name: org.apache.maven.plugins:maven-failsafe-plugin
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Bump org.apache.maven.plugins:maven-surefire-plugin in /finish

Bumps [org.apache.maven.plugins:maven-surefire-plugin](https://github.com/apache/maven-surefire) from 3.3.0 to 3.3.1.
- [Release notes](https://github.com/apache/maven-surefire/releases)
- [Commits](apache/maven-surefire@surefire-3.3.0...surefire-3.3.1)

---
updated-dependencies:
- dependency-name: org.apache.maven.plugins:maven-surefire-plugin
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
README.adoc Show resolved Hide resolved
README.adoc Outdated Show resolved Hide resolved
@gkwan-ibm
Copy link
Member

  • search the role requirement from azure doc for users to create resource group, then add those prereq in the content

@gkwan-ibm
Copy link
Member

gkwan-ibm commented Aug 9, 2024

  • It is better to simplify the content of the Provision deployment foundation with Liberty on AKS section. The guide has no need to describe in detail like as a doc. Users only need to provide info in the Basics pane and leave other panes as default. After filling up the Basics pane, they can click the Review+Create button to create the resources group and cluster. Let the guide to demonstrate how simple to create them. Just mention that if interest to know more configuration, they can visit the other panes.
  • in the Access the created cluster section, is there a command, e.g. az aks show, to get the [cluster-name] instead of from the GUI?
  • clusterXXXXXX in the output can be replaced by a makeup string, e.g. cluster1234d5
  • in the Logging into the container registry subsection, can add a command to get the [registry-name]? In this case, screenshot can be kept.

@gkwan-ibm
Copy link
Member

gkwan-ibm commented Aug 13, 2024

  • remove
    • Please note, the plan also supports to use an existing resource group while the group is required to be empty.

  • Before this statement "To push Docker images to your registry, you must log in to your Azure Container Registry by using the Azure CLI.", need to tell users which value is the [registry-name], e.g. acr1234d5 under the NAME column from the output

gkwan-ibm and others added 24 commits January 30, 2025 15:31
Co-authored-by: David Mueller <[email protected]>
Co-authored-by: David Mueller <[email protected]>
Co-authored-by: David Mueller <[email protected]>
Co-authored-by: David Mueller <[email protected]>
Co-authored-by: David Mueller <[email protected]>
Co-authored-by: David Mueller <[email protected]>
Co-authored-by: David Mueller <[email protected]>
Co-authored-by: David Mueller <[email protected]>
Co-authored-by: David Mueller <[email protected]>
Co-authored-by: David Mueller <[email protected]>
Co-authored-by: David Mueller <[email protected]>
Co-authored-by: David Mueller <[email protected]>
Co-authored-by: David Mueller <[email protected]>
Co-authored-by: David Mueller <[email protected]>
Co-authored-by: David Mueller <[email protected]>
Co-authored-by: David Mueller <[email protected]>
Co-authored-by: David Mueller <[email protected]>
Co-authored-by: David Mueller <[email protected]>
Co-authored-by: David Mueller <[email protected]>
Co-authored-by: David Mueller <[email protected]>
Co-authored-by: David Mueller <[email protected]>
Co-authored-by: David Mueller <[email protected]>
Co-authored-by: David Mueller <[email protected]>
Copy link
Member

@dmuelle dmuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ID LGTM, thanks

* use versionless feature

Signed-off-by: Gilbert Kwan <[email protected]>

* use versionless feature

Signed-off-by: Gilbert Kwan <[email protected]>

* use versionless feature

Signed-off-by: Gilbert Kwan <[email protected]>

---------

Signed-off-by: Gilbert Kwan <[email protected]>
Copy link
Member

@gkwan-ibm gkwan-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified end-to-end and had no issue

@yeekangc yeekangc self-requested a review January 31, 2025 19:12
Copy link
Member

@yeekangc yeekangc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, everyone! Let us proceed to publish.

@gkwan-ibm gkwan-ibm merged commit 96779f4 into staging Feb 10, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Final end-to-end testing
Development

Successfully merging this pull request may close these issues.

5 participants