Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incomplete Java 8 support: Fix IT #1626

Closed
bmarwell opened this issue Jan 20, 2023 · 3 comments
Closed

Incomplete Java 8 support: Fix IT #1626

bmarwell opened this issue Jan 20, 2023 · 3 comments

Comments

@bmarwell
Copy link
Contributor

Due to my incomplete PR for #1617, there's still a test which needs to be addressed.
bmarwell added a commit to bmarwell/ci.maven that referenced this issue Jan 20, 2023
@bmarwell
[OpenLiberty#1626] update dev-it to Java 8 as well.
97717e0
mattbsox pushed a commit that referenced this issue Jan 20, 2023
@bmarwell
[#1626] update dev-it to Java 8 as well. (#1627)
26148cb
@bmarwell bmarwell mentioned this issue Jan 22, 2023
Open
@bmarwell
Copy link
Contributor Author

bmarwell commented Feb 8, 2023

Are you going to merge this at any point?

@cherylking
Copy link
Member

Are you going to merge this at any point?

I don't see any open PRs from you waiting to be merged. Which item were you wanting merged?

@bmarwell bmarwell closed this as completed Feb 9, 2023
@bmarwell
Copy link
Contributor Author

bmarwell commented Feb 9, 2023

Oh! I forgot to add the magic keyword "fixes". Sorry!

Fixed by: 97717e0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bmarwell @cherylking