-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/network led #11
base: v1dev
Are you sure you want to change the base?
Changes from all commits
86d824c
d4a17f9
63fb76f
3564fdf
ce0c7aa
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -37,6 +37,10 @@ | |
#include "UsbExchangeModule.h" | ||
#endif | ||
|
||
#if !defined(OPENKNX_LED_IP) && defined(INFO2_LED_PIN) && KNX_SERVICE_FAMILY != 0x02 // IP-Router uses own LED implementation | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. SERVICE_FAMILY ist kein geeignetes Unterscheidungsmerkmal für den Router. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ich bin gegen eine default Zuweisung. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ich bin auch gegen default. wenn es jemand braucht, soll er es zuweisen. vor allem weil auch nur die progled pflicht und empfohlen infoled (infoled1) ist. |
||
#define OPENKNX_LED_IP info2Led | ||
#endif | ||
|
||
typedef std::function<void(bool)> NetworkChangeCallback; | ||
|
||
class NetworkModule : public OpenKNX::Module | ||
|
@@ -93,6 +97,9 @@ class NetworkModule : public OpenKNX::Module | |
bool _useMDNS = false; | ||
bool _otaAllowed = false; | ||
bool _otaHandle = false; | ||
#ifdef OPENKNX_LED_IP | ||
uint8_t _ipLedState = 0; | ||
#endif | ||
#ifdef ARDUINO_ARCH_ESP32 | ||
const uint16_t _otaPort = 3232; | ||
const char *_otaPortString = "3232"; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hier wäre noch schön wenn das LED-Bild erklärt würde (welche Farbe/Zustand was bedeutet)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
und ich wäre auch noch für das passende namensschema:
OPENKNX_NETWORK_INFOLED
außerdem bin ich kein freund davon coden namen zu verwenden da es eine spätere anpassung verhindert.
wäre also eher für
-D OPENKNX_NETWORK_INFOLED=2
für info2led.
evtl bekommen wir sogar noch eine activity anzeige hin. zumindest wenn es ein IP Device ist und ein telegramm per ip eingeht.