Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-up imports. #1123

Merged
merged 4 commits into from
Dec 11, 2024
Merged

Clean-up imports. #1123

merged 4 commits into from
Dec 11, 2024

Conversation

Delta-473
Copy link
Collaborator

@Delta-473 Delta-473 commented Dec 9, 2024

I don't know if this are all the imports that can be removed but it's already a lot of them. Can't compile everything successful atm, nQuant is giving issues but idk if that's an issue on my machine or if Rider has borked something.

Update

ll7f77rl7d871

I don't know if this are all the imports that can be removed but it's already a lot of them.
@Delta-473
Copy link
Collaborator Author

Well it failed in the pipeline, something got borked.

@Delta-473
Copy link
Collaborator Author

Ok why did it update the nQuant submodule?

@kenjiuno
Copy link
Collaborator

Please update the nQuant submodule by running git submodule update --remote -- nQuant

V:\OpenKh-delta473>git submodule update --remote -- nQuant
Submodule path 'nQuant': checked out 'cb6f856770e5618c6b38067dab5500ef252c0e58'

OpenKH/nQuant@cb6f856 is the latest commit for now.

@Delta-473
Copy link
Collaborator Author

That worked thanks. :)

@Delta-473 Delta-473 marked this pull request as ready for review December 10, 2024 08:08
Copy link
Collaborator

@shananas shananas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got 6649 less removals and 7078 less additions than promised

@shananas shananas merged commit 4aa9e6b into OpenKH:master Dec 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants