fix: stop overwriting safe_mode config.yaml setting with default in args #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, great catch Eric! Merging. |
joshuavial
pushed a commit
to joshuavial/open-interpreter
that referenced
this pull request
Nov 16, 2023
…ont-overwrite-config-with-defaults fix: stop overwriting safe_mode config.yaml setting with default in args Former-commit-id: 2d85003 Former-commit-id: 9cd00e7ce5410855213c2027318c16ba4d3424d0 Former-commit-id: d4f4737d4f4234097be4912d16b9f0ab042ed344 [formerly 1a9445c89ce448e40b1b9bb7eab884c624b84689] Former-commit-id: 9b22617a187a7ad2cb05e7d336fb5ad873492fbe
joshuavial
pushed a commit
to joshuavial/open-interpreter
that referenced
this pull request
Nov 16, 2023
…ont-overwrite-config-with-defaults fix: stop overwriting safe_mode config.yaml setting with default in args
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes you have made:
safe_modefromconfig.yamlwas being overwritten by thedefaultoption set in the arguments config. I forgot that we already have a default value in thecore.pyInterpreterinstance and the way args were being handled meant that the default value functionality I added in #511 was actually overriding the value fromconfig.yaml.Reference any relevant issue (Updates #484)
I have tested the code on the following OS:
AI Language Model (if applicable)