-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:Add support for containerized Code execution, and utilities ( upload / download fn ). #459
Changes from 6 commits
6ae3f20
54b2451
03fb194
2e1f7bf
acb8dbc
1858ffb
e2716cd
30f8114
e770bd0
df2a44f
3907b16
295ddfa
8884506
2af31a9
1288831
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"python.analysis.typeCheckingMode": "basic" | ||
} |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not sure if you meant to make changes to this file? |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Outside of the new Maybe they were picked up in a rebase/merge or something? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I did do it on purpose. the reasoning was because, if we return a instance when we import, we cant access other things in the package like the containerConfig ( DockerManager ) class. I figured may aswell do this factory fn since making it so that the interpreter class has more methods to get to the container config would be messy. |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this might be an editor automated formatting thing, too. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this was because of the init.py change. we just simply instanciate the interpreter in the function so we don't need to change the CLI entrypoint. everything functions identically to before. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should double-check with @KillianLucas whether we want to start bringing in things like VSCode project-level settings before we commit any of them to the repo.