Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sensor: set correct page for superpix detection #105

Merged
merged 1 commit into from
Dec 17, 2023
Merged

sensor: set correct page for superpix detection #105

merged 1 commit into from
Dec 17, 2023

Conversation

viktorxda
Copy link
Collaborator

No description provided.

@viktorxda viktorxda force-pushed the sstar branch 2 times, most recently from 923fe2c to 1f9c5e0 Compare December 16, 2023 09:07
Copy link
Member

@flyrouter flyrouter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the additions, I have no objections and I think that @widgetii and @dimerr will look into this soon

src/hal/common.c Outdated Show resolved Hide resolved
@widgetii
Copy link
Member

LGTM from my point of view. Anyway sensor detection is tricky, so the only approach is a try and an error method

@viktorxda
Copy link
Collaborator Author

I checked the other sensors and 0xFD seems to be a common register: SP2305.
However, if there are any issues with Superpix in the future this commit can be reverted.

@viktorxda viktorxda merged commit 0f89267 into master Dec 17, 2023
@viktorxda viktorxda deleted the sstar branch December 17, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants