Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ—πŸ”§οΌšpre-empt our new dark theme #1131

Merged
merged 107 commits into from
Apr 5, 2024
Merged

πŸ—πŸ”§οΌšpre-empt our new dark theme #1131

merged 107 commits into from
Apr 5, 2024

Conversation

DerekNonGeneric
Copy link
Member

coming soon

@netlify Netlify
Copy link

netlify bot commented Feb 7, 2024 •
edited
Loading

πŸ‘· Deploy Preview for open-inf-is processing.

Name Link
πŸ”¨ Latest commit 4d16b37
πŸ” Latest deploy log https://app.netlify.com/sites/open-inf-is/deploys/65fb9939f6adf1000828106a

@DerekNonGeneric DerekNonGeneric linked an issue Feb 7, 2024 that may be closed by this pull request
πŸš› doom scrolling literally causes site to malfunction [Dark Reader] #1124
Closed
1 task
DerekNonGeneric
DerekNonGeneric commented Feb 7, 2024
View reviewed changes
_layouts/default.html Outdated Show resolved Hide resolved
DerekNonGeneric
DerekNonGeneric commented Feb 7, 2024
View reviewed changes
_layouts/default.html Outdated Show resolved Hide resolved
DerekNonGeneric
DerekNonGeneric commented Feb 8, 2024
View reviewed changes
_layouts/default.html Outdated Show resolved Hide resolved
DerekNonGeneric
DerekNonGeneric commented Feb 8, 2024
View reviewed changes
_layouts/docs.html Outdated Show resolved Hide resolved
DerekNonGeneric
DerekNonGeneric commented Feb 8, 2024
View reviewed changes
index.html Outdated Show resolved Hide resolved
@OpenINFbot
Copy link
Member

coming soon

sure, if you can pass the validators, you can also add the valid HTML5 web badge

@OpenINF OpenINF deleted a comment from OpenINFbot Feb 8, 2024
DerekNonGeneric
DerekNonGeneric commented Feb 8, 2024
View reviewed changes
_config.yml Outdated Show resolved Hide resolved
DerekNonGeneric
DerekNonGeneric commented Feb 8, 2024
View reviewed changes
_config.yml Outdated Show resolved Hide resolved
@DerekNonGeneric
Copy link
Member Author

while we're here, i was thinking that we could v. quickly add an actual splash page template ^^

@DerekNonGeneric DerekNonGeneric added the πŸš… Status: Fast Track PRs that do not need to wait for 48 hours to land label Feb 8, 2024
@DerekNonGeneric
Copy link
Member Author

DerekNonGeneric commented Feb 8, 2024 •
edited
Loading

oh my goodness lol:

@DerekNonGeneric
Copy link
Member Author

here is the splash template i had in mind...

πŸ”— https://mmistakes.github.io/minimal-mistakes/docs/layouts/#splash-page-layout

This was linked to issues Feb 8, 2024
🏷️ Structured pages (SEO) #576
Closed
🎨✨ adopting sanitize.css #851
Closed
πŸ› still missing org custom templates for our error pages #1098
Closed
πŸ—οΈ separating assets for light/dark themes into different directories #1119
Closed
OpenINFbot
OpenINFbot reviewed Mar 28, 2024
View reviewed changes
_config.yml Outdated Show resolved Hide resolved
@DerekNonGeneric @OpenINFbot
Update _config.yml
303bb17 
Co-authored-by: OpenINF Bot <[email protected]>
Signed-off-by: Derek Lewis <[email protected]>
DerekNonGeneric
DerekNonGeneric commented Mar 28, 2024
View reviewed changes
assets/scss/collections.scss
@@ -0,0 +1,26 @@
---
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

main thing i want to be sure we don't break before merging as-is:

the collections page has custom styles

DerekNonGeneric
DerekNonGeneric commented Mar 28, 2024
View reviewed changes
Copy link
Member Author

@DerekNonGeneric DerekNonGeneric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we will not be integrating rubocop in this pr;

the whole task is its own deal

@DerekNonGeneric DerekNonGeneric mentioned this pull request Mar 28, 2024
Open
1 task
OpenINFbot
OpenINFbot reviewed Mar 31, 2024
View reviewed changes
Gemfile Outdated Show resolved Hide resolved
@OpenINFbot
Update Gemfile
4dbe803 
Signed-off-by: OpenINF-bot <[email protected]>
OpenINFbot
OpenINFbot reviewed Mar 31, 2024
View reviewed changes
_layouts/compress.html Outdated Show resolved Hide resolved
DerekNonGeneric
DerekNonGeneric commented Mar 31, 2024
View reviewed changes
_layouts/compress.html Outdated
@@ -1,5 +1,5 @@
---
##
##
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, here is where dev and prod matters; also we are removing these (as mentioned)

@OpenINFbot OpenINFbot added πŸŒ— P2: Medium undefined and removed πŸ—³οΈ Status: Author Ready PRs that are considered ready by their author πŸ”₯ P0: Critical Drop everything labels Apr 1, 2024
@DerekNonGeneric DerekNonGeneric force-pushed the live branch 4 times, most recently from 5654a37 to 33d717a Compare April 5, 2024 19:19
@OpenINFbot OpenINFbot merged commit b15cc0e into OpenINF:live Apr 5, 2024
15 of 16 checks passed
DerekNonGeneric added a commit that referenced this pull request Apr 5, 2024
@DerekNonGeneric
Revert "πŸ—πŸ”§οΌšpre-empt our new dark theme #1131"
f4f86a8 
This reverts commit b15cc0e.
DerekNonGeneric added a commit that referenced this pull request Apr 11, 2024
@DerekNonGeneric
Revert "Revert "πŸ—πŸ”§οΌšpre-empt our new dark theme #1131""
774f76c 
This reverts commit f4f86a8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OpenINFbot OpenINFbot OpenINFbot approved these changes

Assignees

@DerekNonGeneric DerekNonGeneric

@OpenINFbot OpenINFbot

Labels
♿️ Category: Accessibility Issues and PRs related to accessibility (WCAG, etc.) πŸ’„ Category: CSS/Styling undefined 🌐 Category: Localization undefined 🚸 Category: User Experience (UX) undefined πŸ’Ž Code: Ruby PRs or issues regarding Ruby code πŸŒ— P2: Medium undefined πŸ›„ Status: Claimed Issues that have been claimed to be undertaken by someone πŸš… Status: Fast Track PRs that do not need to wait for 48 hours to land 🚧 Status: Work In Progress (WIP) undefined πŸ—’οΈ todo PRs that add code with TODO comments ✨ Type: Enhancement undefined ✨ Type: Feature undefined
Projects
None yet
Milestone
No milestone
3 participants
@DerekNonGeneric @OpenINFbot @restyled-commits