Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coin sorter V2 corrected with tests #652

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kochebina
Copy link
Contributor

@tbaudier @nkrah @dsarrut

I don't know what happened to the prev. PR for CoinSorter... but here it the new one.
The corrected version of it is in this PR.
It is ready!

The ref data to be copied to opengate/tests/data/output_ref/test072 is here:
https://doi.org/10.6084/m9.figshare.28063244.v1

@tbaudier
Copy link
Contributor

Hello @kochebina

I integrated the data but the tests are failling. For example:

(venv) (base) tbaudier@eq4-tb-693 src % python test072_coinc_sorter_2keep_all.py
Opening /Users/tbaudier/Software/GatePython/opengate/opengate/tests/output/test072_coinc_sorter/test72_output_1.root ...
There are 7685 singles
{'EventID': 'int32_t', 'PostPosition_X': 'double', 'PostPosition_Y': 'double', 'PostPosition_Z': 'double', 'TotalEnergyDeposit': 'double', 'PreStepUniqueVolumeID': 'char*', 'GlobalTime': 'double'}
Traceback (most recent call last):
  File "/Users/tbaudier/Software/GatePython/opengate/opengate/tests/src/test072_coinc_sorter_2keep_all.py", line 69, in <module>
    main()
  File "/Users/tbaudier/Software/GatePython/opengate/opengate/tests/src/test072_coinc_sorter_2keep_all.py", line 48, in main
    coincidences = coincidences_sorter(
TypeError: coincidences_sorter() missing 1 required positional argument: 'maxDistanceZ'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants