-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CoinSorter v2 advanced #410
Conversation
a2a7cd1
to
01f95ee
Compare
f87ee87
to
4b9795a
Compare
@tbaudier, could you, please, update the tests ? Or should I do the tests update in a different PR ? |
aed5d25
to
9aadadb
Compare
40f4602
to
a60fef7
Compare
What's the status on this? The tests provided by this PR do not seem to pass. Is there an issue to be solved? |
Hi Nils, There are several things:
Cheers, |
Great. Please post here if you want anyone to review the code or if you think the PR is ready to be considered for merging. |
@nkrah |
366607b
to
2112bcd
Compare
This PR is ready to be merged. |
2112bcd
to
b748e0d
Compare
ref data for test072 is here:
https://doi.org/10.6084/m9.figshare.25992610.v1