Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to sort ScopedKeys #199

Merged
merged 3 commits into from
Dec 4, 2023
Merged

Add ability to sort ScopedKeys #199

merged 3 commits into from
Dec 4, 2023

Conversation

dotsdl
Copy link
Member

@dotsdl dotsdl commented Nov 14, 2023

Closes #198.

@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (76c439c) 82.25% compared to head (2d8aa18) 82.32%.

Files Patch % Lines
alchemiscale/models.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #199      +/-   ##
==========================================
+ Coverage   82.25%   82.32%   +0.07%     
==========================================
  Files          22       22              
  Lines        2739     2739              
==========================================
+ Hits         2253     2255       +2     
+ Misses        486      484       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dotsdl dotsdl requested a review from ianmkenney December 4, 2023 18:18
@dotsdl
Copy link
Member Author

dotsdl commented Dec 4, 2023

@ianmkenney can I get a review from you on this one? No rush.

Copy link
Member

@ianmkenney ianmkenney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dotsdl
Copy link
Member Author

dotsdl commented Dec 4, 2023

@ianmkenney danke! Merging!

@dotsdl dotsdl merged commit bf2323d into main Dec 4, 2023
3 checks passed
@dotsdl dotsdl deleted the sort-scopedkey branch December 4, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make ScopedKeys sortable
3 participants