This repository has been archived by the owner on Feb 5, 2024. It is now read-only.
Uploaded the design decisions #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I forgot to upload the design decisions - sorry!
vringar
suggested changes
Aug 21, 2022
docs/design_decisions_paho.md
Outdated
| |--|--|--| | ||
| |<b>Overview</b>|Tahu with Sparkplug support|Paho with generic MQTT support| | ||
| |<b>Link</b>|[Tahu](https://github.com/eclipse/tahu)|[Paho](https://www.eclipse.org/paho)| | ||
| |<b>Benefits and risks</b>|+ JAVA|+ Python<br>+ generic MQTT support| |
There was a problem hiding this comment.
What does python have to do with any of this?
We were considering two different Java libraries? Right?
There was a problem hiding this comment.
Oh my fault, I thought Paho was Python only. I will change that too
docs/design_decisions_server.md
Outdated
|
|
||
| |Solution hypothesis| | ||
| |--------------| | ||
| |The MatterHub can interact with the Enddevice once the program is implemented.| |
There was a problem hiding this comment.
Don't you mean that the IOT things cloud can interact with the end device? Because the mattterhub and the enddevice are on the same side of this discussing.
There was a problem hiding this comment.
yeah you are right, I changed that
|
You can also just merge these and then fix 'em up for the report, but these two things confused me. |
|
@vringar I changed the Paho Design Decision. Now it's ready to merge, what do you think? |
vringar
approved these changes
Aug 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot to upload the design decisions - sorry!
#64 #56
Pull Request Checklist
Author
Reviewer