Skip to content
This repository has been archived by the owner on Feb 5, 2024. It is now read-only.

Automation for Mac #59

Merged
merged 9 commits into from
Aug 19, 2022
Merged

Automation for Mac #59

merged 9 commits into from
Aug 19, 2022

Conversation

Emirhan-Atabay
Copy link
Contributor

@Emirhan-Atabay Emirhan-Atabay commented Jul 2, 2022

Pull Request Checklist

Automates and simplifies the building process on Mac.

Author

  • Built code and tested locally
  • Removed any TODOs, etc.
  • Metioned the issue this PR closes
  • Good description of what the PR does written

Reviewer

  • Built and tested code locally
  • Fully understood the PR
  • All open conversations resolved

@Emirhan-Atabay Emirhan-Atabay requested a review from TuCl July 2, 2022 00:13
@Emirhan-Atabay Emirhan-Atabay self-assigned this Jul 2, 2022
@Emirhan-Atabay
Copy link
Contributor Author

#53

Bug fix: We don't need to delete the sdkconfig anymore
Bug fix: We don't need to delete the sdkconfig anymore
Bug fix: We don't need to delete the sdkconfig anymore
@TuCl
Copy link
Contributor

TuCl commented Jul 4, 2022

Comments:

sh file should be started from terminal not by "click" - Replace the "click" command accordingly.

"Type in yes or click enter" - this is confusing (it suggests that typing yes and clicking enter has the same functionality)

Errors:

23:84: execution error: „Terminal“ hat einen Fehler erhalten: „window 3“ kann nicht gelesen werden. (-1728)
autostart process is completed!

I tried this inside VSCode Terminal, I will try again with Mac Terminal

@TuCl
Copy link
Contributor

TuCl commented Jul 4, 2022

After clicking enter inside the Mac Terminal a new Window opens with this error:

cd .; source ./settings.sh; sh ./hub_start.sh
source: no such file or directory: ./settings.sh
sh: ./hub_start.sh: No such file or directory

cd .; source ./settings.sh; sh ./enddevice_start.sh
source: no such file or directory: ./settings.sh
sh: ./enddevice_start.sh: No such file or directory

Matterpath is set to export MATTERPATH="/Users/ctu/ADSP/matterHub" where the matterHub folder is the root of the GitHub project.

@Emirhan-Atabay
Copy link
Contributor Author

Okay that should not actually be so. It does not recognize your settings.sh.
I am thinking of a solution for this problem.

"sh file should be started from terminal not by "click"" I think that's easier for the users. You can start it from the terminal too. The users should decided it for their own.

@Emirhan-Atabay
Copy link
Contributor Author

Do you tried to double click on autostart.sh without trying to start it with the Terminal? It's possible that bash don't like this command: BASEDIR=$(dirname "$0"). It's not working when you try to start it with the Terminal.
Try this instead:
Go to the autostart.sh file and right click on it, select open with Terminal. I think I should change that anyway so that you can open it with the Terminal too.

@Emirhan-Atabay
Copy link
Contributor Author

Okay, it should work now!

@vringar vringar merged commit 2b8bdc8 into main Aug 19, 2022
@vringar vringar deleted the auto_mac branch August 19, 2022 07:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants