Advanced parametrized type resolution for AsyncFeign #1623
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've faced an issue that
AsyncFeign
does not resolve generic parameters correctly when clients are also parametrized — for example, sync and async with a common parameterized interface for return types.Feign
works just fine:But
AsyncFeign
failsI traced this down to
MethodInfo
where it does very basic detection unlikeContract.parseAndValidateMetadata()
which is used byFeign
to create an invocation handler.The solution I propose is to use the same type-resolution that
Contract
does here insideMethodInfo
.