Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSON-java decoder and encoder #1387

Merged
merged 10 commits into from
Jun 30, 2021
Merged

Conversation

vitalijr2
Copy link
Collaborator

Added module for encoding and decoding using JSON-java.

Implements #1385

Copy link
Member

@velo velo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work @radio-rogal , I asked for a few changes, lemme know how it goes.

@velo velo added enhancement For recommending new capabilities feedback provided Feedback has been provided to the author waiting for votes Enhancements or changes proposed that need more support before consideration labels Apr 22, 2021
…DME, use instanceof instead of references (JsonEncoder)
@vitalijr2
Copy link
Collaborator Author

@velo done

@velo velo added ready to merge Will be merged if no other member ask for changes and removed feedback provided Feedback has been provided to the author waiting for votes Enhancements or changes proposed that need more support before consideration labels Jun 30, 2021
@velo velo merged commit 5087bd8 into OpenFeign:master Jun 30, 2021
@vitalijr2 vitalijr2 deleted the feature/feign-json branch July 1, 2021 12:33
velo added a commit that referenced this pull request Oct 7, 2024
* Provides decoder and encoder for JSON-java

* Rename feign-json to feign-org.json, add link to JSON web-site to README, use instanceof instead of references (JsonEncoder)

* Return back feign-json, JSON-java

* Fix parent version

* Added JSON-java decoder to decoders list

* Increase coverage: empty response body, parsing exception is caused by another exception

* Use isAssignableFrom to allow methods return extended JSONObject and JSONArray classes

Co-authored-by: Marvin Froeder <[email protected]>
velo added a commit that referenced this pull request Oct 8, 2024
* Provides decoder and encoder for JSON-java

* Rename feign-json to feign-org.json, add link to JSON web-site to README, use instanceof instead of references (JsonEncoder)

* Return back feign-json, JSON-java

* Fix parent version

* Added JSON-java decoder to decoders list

* Increase coverage: empty response body, parsing exception is caused by another exception

* Use isAssignableFrom to allow methods return extended JSONObject and JSONArray classes

Co-authored-by: Marvin Froeder <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement For recommending new capabilities ready to merge Will be merged if no other member ask for changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants