-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JSON-java decoder and encoder #1387
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
velo
requested changes
Apr 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work @radio-rogal , I asked for a few changes, lemme know how it goes.
…DME, use instanceof instead of references (JsonEncoder)
@velo done |
…y another exception
…JSONArray classes
velo
approved these changes
Jun 30, 2021
kdavisk6
approved these changes
Jun 30, 2021
velo
added a commit
that referenced
this pull request
Oct 7, 2024
* Provides decoder and encoder for JSON-java * Rename feign-json to feign-org.json, add link to JSON web-site to README, use instanceof instead of references (JsonEncoder) * Return back feign-json, JSON-java * Fix parent version * Added JSON-java decoder to decoders list * Increase coverage: empty response body, parsing exception is caused by another exception * Use isAssignableFrom to allow methods return extended JSONObject and JSONArray classes Co-authored-by: Marvin Froeder <[email protected]>
velo
added a commit
that referenced
this pull request
Oct 8, 2024
* Provides decoder and encoder for JSON-java * Rename feign-json to feign-org.json, add link to JSON web-site to README, use instanceof instead of references (JsonEncoder) * Return back feign-json, JSON-java * Fix parent version * Added JSON-java decoder to decoders list * Increase coverage: empty response body, parsing exception is caused by another exception * Use isAssignableFrom to allow methods return extended JSONObject and JSONArray classes Co-authored-by: Marvin Froeder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
For recommending new capabilities
ready to merge
Will be merged if no other member ask for changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added module for encoding and decoding using JSON-java.
Implements #1385