Fix expansion of @RequestParam empty lists #1200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdavisk6
approved these changes
Apr 6, 2020
kdavisk6
added
ready to merge
|
A note on Travis, the build succeeded however the status did not make it back to GitHub. This PR is green. |
jebeaudet
pushed a commit
to coveord/feign
that referenced
this pull request
Apr 24, 2020
* Add list tests to QueryTemplateTest * Make expandIterable() return empty string if unresolved * Rename new tests to fit existing tests * Format code * Fix newlines
velo
pushed a commit
that referenced
this pull request
Oct 7, 2024
* Add list tests to QueryTemplateTest * Make expandIterable() return empty string if unresolved * Rename new tests to fit existing tests * Format code * Fix newlines
velo
pushed a commit
that referenced
this pull request
Oct 8, 2024
* Add list tests to QueryTemplateTest * Make expandIterable() return empty string if unresolved * Rename new tests to fit existing tests * Format code * Fix newlines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #1197.
Expressions.expandIterable()(link), expands an empty list intonull, which gets returned toexpand(), whoseStringBuilderappends anull.StringBuilderwill append a literalnullto the internal string buffer, resulting in an expansion of an empty list into something like/items?manufacturer=null, which will be serialized by the caller as a singleton list with a singlenull.This PR modifies
expandIterable()to return an empty string instead ofnullin the case of an empty list.