Pass Python_EXECUTABLE from main OF cmake to external pfunit cmake #1948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows pfunit to use the same interpreter found by the main OF cmake. NOTE: pfunit uses `PYTHON_EXECUTABLE`
deslaughter
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is ready to merge.
Feature or improvement description
This allows pfunit to use the same interpreter found by the main OF cmake. Also adds check that the Python version is less than 3.12.
Related issue, if one exists
No GH issues related. However, the latest
homebrewinstall on the Mac wants to use Python 3.12, which is incompatible with the version of pfunit (3.2.10) we are currently using.Impacted areas of the software
Unit testing under certain scenarios is improved.
Additional supporting information
NOTE: pfunit uses
PYTHON_EXECUTABLEinternally rather thanPython_EXECUTABLEwhich is returned by thefind_package(Python ...)command.For a specific Python version, specifying either
-DPython_EXECUTABLE:FILEPATH=...or-DPython_ROOT_DIR=...for cmake will result in pfunit getting the correct info.Test results, if applicable
No test results change.