AeroDyn14 removal #1429
Closed
AeroDyn14 removal #1429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-platt
force-pushed
the
f/AD14remove
branch
from
46b1c99 to
1b7d6b1
Compare
ebranlard
approved these changes
Feb 1, 2023
jjonkman
requested changes
Feb 10, 2023
There was a problem hiding this comment.
Thanks for addressing this long-awaited deprecation of AeroDyn v14!
ElastoDyn blade input PitchAxis was only used with AeroDyn v14. Now that AeroDyn v14 has been removed, PitchAxis should be removed from the ElastoDyn blade input file.
This PR addresses issue #93.
andrew-platt
force-pushed
the
f/AD14remove
branch
from
a97de42 to
033b5d2
Compare
- Regression tests with AD14 converted to AD15, but not tuned correctly yet. - update docs to not mention AD14 - update error handling in parsing .fst files
There were comments about ADAMS still in this. Nothing about AD14 though.
These test cases were unstable with AD14 and did not correspond well when upgraded to AD15. Thus we decided to simply remove them for now.
andrew-platt
force-pushed
the
f/AD14remove
branch
from
033b5d2 to
ce407b9
Compare
Merged
|
Closing since #2267 supercedes this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is not ready for merging (regression tests must be dealt with first).
Feature or improvement description
The AeroDyn14 module was a carry-over from FAST v7 to FAST v8 as a stop-gap while AeroDyn15 was under development. As such AeroDyn14 was never converted to the FAST Modular Framework; this created many code workarounds in ElastoDyn and in the openfast-library to get it to work. At this point AeroDyn15 is far more comprehensive than AeroDyn14 so very few users ever use it. Therefore the plan for many years has been to remove it entirely, and now we finally got around to it.
Related issue, if one exists
#527 -- bug with AD14 tower
#93 -- deprecating AD14
OpenFAST/r-test#43
Impacted areas of the software
There are some significant improvements to the glue code and ElastoDyn with the removal of AD14.
Several code development projects are depending on this PR.
CompAero==3)CompAero==1)Additional supporting information
The regression tests that previously used AeroDyn14 have been updated to AeroDyn15, but have not been tuned correctly for the DBEMT parameters (in particular the
Tautime constants). Some of these cases also show instabilities and had been turned off as a result. We need to decide which cases we will simply remove, and which we will keep.Test results, if applicable
Regression tests with AD14 converted to AD15, but not tuned correctly yet.