Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add static link of header image #585 #587

Merged
merged 3 commits into from
Nov 7, 2024
Merged

Conversation

FlorianK13
Copy link
Member

Workflow checklist

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guidelines
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@FlorianK13 FlorianK13 linked an issue Oct 23, 2024 that may be closed by this pull request
@FlorianK13 FlorianK13 marked this pull request as ready for review October 23, 2024 11:12
@FlorianK13
Copy link
Member Author

Additionally I will try to fix the badge for CI, which is always showing failing

I tried to adapt the style of the badge but I failed.
@FlorianK13
Copy link
Member Author

@nesnoj I repaired the badge. However I was not able to change the style of the badge, stuff like ?style=flat had no impact. For me the label with the current style would be fine.

Copy link
Collaborator

@nesnoj nesnoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@FlorianK13 FlorianK13 merged commit 0a07ea5 into develop Nov 7, 2024
9 checks passed
@FlorianK13 FlorianK13 deleted the 585-repair-header-image branch November 7, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Header image is not shown on PyPI
2 participants