Tesla API support #67
Conversation
| for (int i=0;i < _vehicleCnt;i++) { | ||
| JsonObject responsei = jresponse[i]; | ||
| _vin[i] = responsei["vin"].as<String>(); | ||
| // doesn't work.. returns converted float _id[i] = responsei["id"].as<String>(); |
There was a problem hiding this comment.
How about:
| // doesn't work.. returns converted float _id[i] = responsei["id"].as<String>(); | |
| _id[i] = String(responsei["id"].as<int>()); |
but equally, if the JSON is a number why save into a String? just use int will save memory and be faster
There was a problem hiding this comment.
It's a 64-bit integer, which is probably why ArduinoMongoose barfs on it. I tried converting my stored string to an integer using strtoul(), and it also barfs:
ID: 28140064781417093 4294967295
ID: 11068998744631046 4294967295
Yes, it's a bit of a waste of memory, but not much
There was a problem hiding this comment.
strtoul is for 32-bit, did you try strtoull? or casting to uint64_t? but in either case yeah not much more memory
| if (!_isBusy()) { | ||
| if ((millis()-_lastRequestStart) > TESLA_REQ_INTERVAL) { | ||
| if (_accessToken.length() == 0) { | ||
| requestAccessToken(); | ||
| } | ||
| else if (_vehicleCnt == 0) { | ||
| requestVehicles(); | ||
| } | ||
| else { | ||
| requestChargeState(); | ||
| } | ||
| } | ||
| } // !busy |
There was a problem hiding this comment.
Not sure this is the best way of doing this, should really send the next request as soon as the previous one is complete, how about only putting the timer around getting the charge state:
| if (!_isBusy()) { | |
| if ((millis()-_lastRequestStart) > TESLA_REQ_INTERVAL) { | |
| if (_accessToken.length() == 0) { | |
| requestAccessToken(); | |
| } | |
| else if (_vehicleCnt == 0) { | |
| requestVehicles(); | |
| } | |
| else { | |
| requestChargeState(); | |
| } | |
| } | |
| } // !busy | |
| if (!_isBusy()) { | |
| if (_accessToken.length() == 0) { | |
| requestAccessToken(); | |
| } | |
| else if (_vehicleCnt == 0) { | |
| requestVehicles(); | |
| } | |
| else if ((millis()-_lastRequestStart) > TESLA_REQ_INTERVAL) | |
| { | |
| requestChargeState(); | |
| } | |
| } // !busy |
There was a problem hiding this comment.
The problem with your suggested fix is that when the credentials are entered incorrectly, or the Tesla servers are just having issues, we're going to be hitting up their servers at a very high rate. Do you really want to do that? If so, I'll commit your suggestion
There was a problem hiding this comment.
True, should probably back off a little under error conditions, Ideally these should be feed back to the UI, but we are not very good at that anywhere :(
|
This a lot @lincomatic From @chris1howell, here are they API web calls for this integrations Telsa user/password/vehicle_index/enable are saved to EEPROM set enable to false to disable it, just like the existing stuff to select which vehicle to fetch charge data for returns JSON of vehicle info e.g
has tesla_user:TESLAUSER,tesla_vehidx:VEHICLEIDX added to the JSON has tesla charge info added to the JSON Data is also published to mqtt:
|
|
One more thing occurred to me, we should probably split the MQTT topics in to generic car charge state and Tesla specific stuff. @glynhudson What is the comparable info that OBMS can provide? |
| server.on("/savetesla$", handleSaveTesla); | ||
| server.on("/saveteslavi$", handleSaveTeslaVI); |
There was a problem hiding this comment.
As an FYI I am currently adding some code that will make these redundant, all new config will be saved by a POST to /config but I will update when I merge. This change means you just have to add two lines in `app_config.cpp' and that will the new config option.
There was a problem hiding this comment.
Take a look at #76, will probably merge this PR first so I can resolve the conflicts
|
Sorry, but I'm pretty swamped these days, and I won't have time to do anything more on this for a while. You're welcome to change it to suit your tastes if there's anything outstanding that you don't like about my implementation. Thanks. |
needs latest ArduinoMongoose from https://github.com/jeremypoulter/ArduinoMongoose