Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gui v2 switch #635

Merged
merged 9 commits into from
May 12, 2023
Merged

Gui v2 switch #635

merged 9 commits into from
May 12, 2023

Conversation

KipK
Copy link
Collaborator

@KipK KipK commented May 9, 2023

Not sure I've missed something here. Perhaps the github action key on openevse gui-v2 repo has to be set?

I've changed the gui directory to gui-v2 to prevent some git error I got if I keep the same path for different submodules

Fixes #616

Copy link
Collaborator

@jeremypoulter jeremypoulter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should remove all the v1 header files as well, and I don't quite understand the reason for changing the folder to gui-v2

.github/workflows/build.yaml Show resolved Hide resolved
@KipK
Copy link
Collaborator Author

KipK commented May 11, 2023

I don't quite understand the reason for changing the folder to gui-v2

I got some references errors on existing cloned repo when it switched to the other "gui" with different submodule repository.
It worked ok when you clone from scratch but not on existing ones when I try to switch back & forth from master and guiv2switch

@jeremypoulter jeremypoulter merged commit acbd1fc into OpenEVSE:master May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to GUI v2
2 participants