-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New settings / flags (#595) #618
Conversation
2c43911
to
04a7561
Compare
@jeremypoulter , I have segfault on divert_sim here. I have modified this (c3c68b7) in divert _sim. Any idea on what I've missed here ? |
@jeremypoulter , when review is ok, don't merge it yet ( same for inputFilter too ). I'll have to merge the gui related branch to master first. Can we decouple the daily builds from the gui commits now ? |
ah also can you bump a new openevse lib version ? |
Just need to remove the workflow in the GUI repo |
Did a new release this morning |
I've removed it and just put a gui build for testing. |
Yeah, testing would be excellent |
Cool thing we can do with svelte is testing each components easily. |
@mathieucarbou , I have changed here the mqtt /restart to /restart {payload} , with payload = "gateway" or "evse" |
oh, nice :-) |
FYI I've grabbed the restart changed in a branch and I have updated my automation when Zoé vehicle is connected. I will report back this week-end hopefully is the sun is helping. |
removed tesla_enabled prop
Still continue use RAPI until 5.0 release ? |
@mathieucarbou You are doing the same thing as enabling that option so the warning applies weither you enable that option or not, but lets keep this discussion in #512 |
Need to also remove the replaced web files. IMHO I see little value in appending the file hash to the file name. The server should properly implement HTTP caching, so it should not be needed. |
I think it's part of Svelte/Vite cache invalidation handler. Not sure it has consequencies to disable it, haven't tested yet. |
Fine to leave it on I guess, but do then need to make sure all the headers are deleted before bringing in a new UI version. Really need to write a GitHub workflow to do that... |
This reverts commit 0769da8.
I have deleted the static files. Is there any need to have the generated statics of related UI commit ? Should stays empty like this on the git |
We commit the static files so you don't have to build the UI to build the firmware. |
ok, i'll update them here after the inputfilter merge. |
UI changes merged in master, we're good on this one too. |
Just the API doc errors to resolve |
Oh ignore that, just noticed you added a change, let me check |
yes should be ok, I've installed the vscode extension and spotted the errors |
FIxes #595
needs UI branch "newflags"
Not to be merged before UI migration
done: