add missing energyMeter data to emoncmss_publish()

[KipK]

forgot this one

Also put the deprecated properties in create_rapi_json as they are missing for emoncms publish

( time to ask emoncms to use the new properties before deprecation )

edit: is there a good reason why data are sent separately to emoncms instead of using event_send like websocket & mqtt?
Also it seems we should send the full /status topic to emoncms instead of create_rapi_json as more data are now coming from ESP32 and not RAPI.

[jeremypoulter]

EmonCMS only accepts numeric data and does not necessarily need all the data exposed by event_send. Also as EmonCMS will typically be remote and WS/MQTT local sending less data is best.

[jeremypoulter]

I think the logic to event the data should be removed from the energy_monitor and just add evse.createEnergyMeterJsonDoc to create_rapi_json so it is inline with the previous implementation and does not hit the EmonCMS severs more than previously

[KipK]

I'm agree, and not sure :) I've wanted to move it out of this create_rapi_json() because it's not RAPI data.
Saying this, there's other data not coming from RAPI in this function like manual_override, freeram, divertmode, srssi, time.
Wouldn't it be cleaner to start separate thoses in prepration of a future properties refactoring ?

edit: for now I've moved it back to create_rapi_json

[jeremypoulter]

For now it is probably best to make that change, we can rename that function to make it clearer that it is not just RAPI if you want.

[KipK]

rebased and ready

[glynhudson]

I've just tested this and total_energy doesn't seem to be posting to Emoncms.org

Apologies, ignore that. I was using the wrong build :-/

It's actually working great 👍