replace old counter from OpenEVSE module with new EnergyMeter class on ESP

[KipK]

Depends new network branch to be migrated first.
now gives :

• session_elapsed
• session_energy
• total_energy
• total_day
• total_week
• total_month
• total_year
• total_switches ( number of time the relay/contactor has turned on/off )

Old OpenEvse total is imported to new counter when migrating first time, then a flag prevent to import it again if counters are reset.

fix #484

[matth-x]

Hi @KipK , these lines were a workaround for reading the updated total energy register during a charging session:

https://github.com/OpenEVSE/ESP32_WiFi_V4.x/blob/59fcb6881232c0ba142ee52de9601c544865c87a/src/ocpp.cpp#L157-L160

The OCPP class expects the energy regsiter reading which accumulates all energy consumption over the lifetime of the EVSE. With the newest EnergyMeter class the workaround should be obsolete and can be removed:

        return (int32_t) evse->getTotalEnergy();

Can you replace those lines?

[KipK]

return (int32_t) evse->getTotalEnergy();

done thanks

[matth-x]

Didn't see that you already updated it in the meantime. Yes, looks perfect 👍

[KipK]

I've rebased the branch for review not network manager has merged.

[jeremypoulter]

Can you remove the draft status if good to go?

[KipK]

I still have one last problem with this branch, the input.cpp loop doesn't seems to run as I don't get the create_rapi_json esach 30 sec anymore.
Haven't found yet what I have removed that create this issue

[KipK]

I still have one last problem with this branch, the input.cpp loop doesn't seems to run as I don't get the create_rapi_json esach 30 sec anymore. Haven't found yet what I have removed that create this issue

I have found, it's because I've removed the getEnergyFromEvse(), was called each 2 sec and was triggering:
_data_ready.ready(EVSE_MONITOR_ENERGY_DATA_READY);

without this input.cpp is not waken up anymore while not charging
My last commit is more a hack than a solution, @jeremypoulter what would be the best way of fixing this ?
The getEnergyFromEnergyMeter I've added is just triggering _data.ready, I guess we can change this for a better way and remove the EVSE_MONITOR_ENERGY_TIME loop, has it's not needed by EnergyMeter

[jeremypoulter]

I need to check, but I think all you have to do is remove EVSE_MONITOR_ENERGY_DATA_READY from the bits that define when the data has all been fetched

[KipK]

Thanks, looks clear now. I'm fixing this

[KipK]

ok fixed & rebased

[jeremypoulter]

Just spotted a bug, I think this should be isCharging to reflect switches of the relay, isActive will increent the count in other cases, eg if the car is not plugged it and the state toggeles from active to disabled.