Adding support for smartEVSE #129
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support per phase info
|
Hi thanks for your PR. It's cool that you have the WiFi module working on the smartEVSE. I've had a look at the changes and I think it would be best to keep them as separate forks, since quite a few changes are required. There also seems to be some changes in this PR which are not directly related to smartEVSE support. What do you think @jeremypoulter @chris1howell ? |
|
That may be wise for now, but we could consider adding official support for different controllers, I certainly have it in the back of my mind in the current work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The accompanying pull request for the gui: OpenEVSE/openevse_wifi_gui#42
This pull request adds support for particular features of smartEVSE: https://www.smartevse.nl/
(The current/default version of EPS32_WiFi_V3.x works, but does not allow control of all smartEVSE features)
The RAPI interface for smartEVSE is implemented in: SmartEVSE/smartevse#39
Let me know what you think about the pull request in its current form: would you indede be willing to consider merging this in one way or form into this repo, or do you prefer me to keep it in a separate fork?