Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Divert mode back-port #260

Merged
merged 20 commits into from
Jul 14, 2020
Merged

Divert mode back-port #260

merged 20 commits into from
Jul 14, 2020

Conversation

jeremypoulter
Copy link
Collaborator

@jeremypoulter jeremypoulter commented Jun 30, 2020

Back-port of the PV divert changes from the ESP32 version (ESP32 V3.2.0 change log), along with a few other fixes/improvements

  • PV Divert changes
  • Updates to save the config as a JSON block
  • Python 3 fixes
  • Latest GUI

Issues (see #259) :

  • Saving the Emoncms service hostname doesn't work, when I save a hostname e.g http://emonpi then look at output of /config the new hostname has not saved. It still shows the default emoncms_server: "https://data.openevse.com/emoncms",. emoncms_node saves correctly.
  • Hostname is openevse-000, I think we should just keep the hostname as it was as just http:/openevse to avoid confusing users who have been using their existing units with this default hostname.
  • After fresh reboot Eco Mode is enabled even though it had never been enabled previously, the UI toggle was showing 'Normal Mode' however /status was showing divertmode: 2,.
  • Available is incorrectly spelt available_current on published MQTT topic name, probably in other places also.
  • When EcoMode is enabled with Grid IE charging does not pause even if there is significant import from the Grid for a period of time. The same issue is present when Solar PV gen is selected and thre is 0W of solar PV Gen, charging does not pause
  • NTP option showing in UI
  • EmonCMS posting returns "Server error: -1"

@jeremypoulter
Copy link
Collaborator Author

@glynhudson

Available is incorrectly spelt available_current on published MQTT topic name, probably in other places also.

I am not quite sure what the request is here, as far as I can see available_current is correct and what is used everywhere

@jeremypoulter
Copy link
Collaborator Author

Pushed a few fixes.

@glynhudson

After fresh reboot Eco Mode is enabled even though it had never been enabled previously, the UI toggle was showing 'Normal Mode' however /status was showing divertmode: 2,.

When EcoMode is enabled with Grid IE charging does not pause even if there is significant import from the Grid for a period of time. The same issue is present when Solar PV gen is selected and thre is 0W of solar PV Gen, charging does not pause

Can you reproduce these on the ESP32 as well?

@glynhudson
Copy link
Contributor

glynhudson commented Jul 1, 2020

Thanks a lot.

I am not quite sure what the request is here, as far as I can see available_current is correct and what is used everywhere

Sorry, my mistake. This is correct.

Can you reproduce these on the ESP32 as well?

No I can't I will double check.

@glynhudson
Copy link
Contributor

glynhudson commented Jul 7, 2020

Hi Jeremy, nice work. I've just tested all the issues above, and they all seem to be fixed 👍

Upon further testing the solar PV divert does seem to be working as expected, I was just getting caught out by the smoothing causing it not to react as fast as I was expecting, this is expected and desirable behaviour. 👍

I've also tested HTTP updating from the current release (V2.8.1) to the new-divert, all the existing setting seemed to port across perfectly 👍

The only remaining issue I seem to have at the moment is I can't get Emoncms to connect. I've tried emoncms.org, local emonPi via IP and hostname. All return server error -1

Screenshot from 2020-07-07 17-01-30

@glynhudson glynhudson merged commit 6e05310 into master Jul 14, 2020
@glynhudson glynhudson deleted the new-divert branch July 14, 2020 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants