Adhoc Mode crash fix #163
Merged
Adhoc Mode crash fix #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Causes 4K of memory to be grabbed while scan takes place, breaking Adhoc mode.
|
Yeah! Fixed 👍 Perfect, thanks so much. Continue in AP mode is such a useful feature. |
Stef-Sijben
pushed a commit
to Stef-Sijben/ESP8266_WiFi_v2.x
that referenced
this pull request
Apr 12, 2019
Adhoc Mode crash fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change 'fixes' #142. The underlying change that 'broke' the AP mode was enabling the Async WiFi scan. This has the inadvertent effect of tying up an additional 4K of RAM because the web request is hanging around for a longer period.
This reverts that change and goes back to the polling method, not quite as nice but at least it works.
Will revisit the ASync WiFi scan if/when ASyncWebserver is a bit more memory friendly.
I also enabled a small optimisation for keeping debug messages in flash now the support for this is stable.