'Fix' for auth crashing the ESP

[jeremypoulter]

I use the term fix very loosely. What this actually does is allow the StaticFileWebHandler to have the authentication separately configured, as with the other handlers, and then not configure authentication.

The effect of this is that only the dynamic content asks for authentication. This should be ok but the underlying bug in the new StaticFileWebHandler is still there.

Fixes #101

[glynhudson]

Nice work, thanks for taking a look at this.

Just tested and it seems to require the username and password to be entered twice. Log in box re-appears for a 2nd time after submitted. Same behaviour on Chrome desktop and android Chrome and Firefox. I double checked I did enter the login details correct the first time!

However, once the login as been entered for the 2nd time it does login every time without hanging which is an improvement.

[jeremypoulter]

The double auth is probably a side effect of only using the auth on the dynamic pages. Which browser are you using? Are you able to get a Wireshark capture?

FYI I tried in Chrome 62.0.3202.94 and only got asked once... Ah are you using the openevse.local address? There is code to swap to IP address to load faster, I think this will be picked up as a separate auth.

[glynhudson]

I'm using Chrome 62.0.3202.97. Ah, that's it! I'm using http://openevse.local: I get asked for one auth when loading openevse.local then a second auth when the DNS resolves to an IP address. If I browse direct to the IP address I only get a single auth. Do you experience a double lookup if you use openevse.local? If not I think we can close this issue since my setup in probably quite unique. My setup might be unique since my router does not support homename lookup I run a local DNS server on a Synology NAS which does DNS lookup for all my local devices then defaults to 8.8.8.8 for external DNS requests. I wonder if this DNS lookup for http://openevse.local is causing the double auth.

…

On 24 November 2017 at 20:53, Jeremy Poulter ***@***.***> wrote: The double auth is probably a side effect of only using the auth on the dynamic pages. Which browser are you using? Are you able to get a Wireshark capture? FYI I tried in Chrome 62.0.3202.94 and only got asked once... Ah are you using the openevse.local address? There is code to swap to IP address to load faster, I think this will be picked up as a separate auth. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

-- Glyn Hudson https://openenergymonitor.org http://zerocarbonadventures.co.uk

[jeremypoulter]

If you are using normal DNS on your router you should use a different domain name like .lan or .home. It is (quite rightly) assumed that .local is going to be a mDNS lookup and hence slow so we do the switch to IP. This is nothing to do with your home setup.

Jeremy

[glynhudson]

Thanks, your totally right. I've just switched to using openevse.home and adjuasted the DNS on my router and it's working great only requiring a single auth now. Issue has been fixed. Thanks again.