Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date off by one day because of timezone #167

Closed
moeabm opened this issue Mar 25, 2018 · 13 comments
Closed

Date off by one day because of timezone #167

moeabm opened this issue Mar 25, 2018 · 13 comments
Assignees
Labels

Comments

@moeabm
Copy link
Contributor

moeabm commented Mar 25, 2018

Im in pacific (-8) timezone. Date field on web gui shows +1 day from 4p-midnight. Should localize time before filling in field. Tested on chrome and FF.

@glynhudson
Copy link
Contributor

What version are you running?

Could this be a replicate of issue #156 that's been fixed in V2.7.0?

@moeabm
Copy link
Contributor Author

moeabm commented Mar 25, 2018

Im on 2.6.0
let me update and check back. Suspect you're right.

@moeabm
Copy link
Contributor Author

moeabm commented Mar 25, 2018

Looks like I still have the issue.

image

@glynhudson
Copy link
Contributor

Oh dear, what time was your browser showing when you clicked 'sync' on the screen gab above? 06:16? Does a manual time set work for you? What browser are you using? Assuming you have tested on a couple of different browsers?

@moeabm
Copy link
Contributor Author

moeabm commented Mar 26, 2018

The time field is accurate. It's the date that is always in GMT. At the time of this screen grab, local time was 3/24/2018 @7:16pm. The system time is correct using auto sync (I've checked the front panel) but the wifi gui is reporting GMT date. Im using chrome but I've also tested firefox with the same result.

@moeabm
Copy link
Contributor Author

moeabm commented Mar 26, 2018

For example, currently, it's 7:15a local time on 3/26. Since GMT is also 3/26, my unit looks accurate. Come 5pm local time, it will change to 3/27/2018.

@glynhudson glynhudson added the bug label Mar 27, 2018
jeremypoulter added a commit to jeremypoulter/ESP8266_WiFi_v2.x that referenced this issue Apr 8, 2018
@ForumLeech
Copy link

Maybe it would be easier and better for ESP8266 to use a time server like time.google.com. A time server's output is simple and stable and knows the daylight savings time schedule for every time zone.
Host web browsers and OS's, as a time source, create challenges as they are multi-factorial and changing.

@chris1howell
Copy link
Member

chris1howell commented Apr 9, 2018 via email

@jeremypoulter
Copy link
Collaborator

This issue would still happen irrespective of if the time came from NTP or OpenEVSE ;-) That being said Shifting the timers etc to the ESP8266 with NTP may have advantages probably should raise as a separate issue about this. IMHO I would only do this if the ESP was less of an optional extra, ie maybe do new LCD board with the ESP module on it.

@glynhudson
Copy link
Contributor

@moeabm this issues should be now fixed in V2.7.1. Please could you test. Thank you

https://github.com/OpenEVSE/ESP8266_WiFi_v2.x/releases/tag/2.7.1

@ForumLeech
Copy link

ForumLeech commented Apr 17, 2018

Previous issue fixed by 2.7.0 resurfaced in 2.7.1. It syncs to a date one month in the past. It was 1:45 AM Pacific Time on 4/17/2018 when I tested it. Happens in multiple web browsers and operating systems. Restart buttons didn't help. Can anybody replicate this bug resurfacing?

@glynhudson
Copy link
Contributor

@ForumLeech thanks for reporting. Yes, your totally right. I'm able to re-create this.

@jeremypoulter are you able to re-create the month syncing one month in the past in 2.7.1? Would you like me to open a new issue for this?

@glynhudson glynhudson reopened this Apr 17, 2018
@glynhudson
Copy link
Contributor

glynhudson commented May 1, 2018

Fixed by #177

New release V2.7.2

Stef-Sijben pushed a commit to Stef-Sijben/ESP8266_WiFi_v2.x that referenced this issue Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants