Added a check for noRetry, received from NodeODM response, so that retrying is stopped in non-recoverability cases #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @theoway 🙏 !! I'll wait until the NodeODM PR is ready also so that I may test. |
|
@pierotofy Here's the NodeODM PR. Let me know if there are changes/enhancements to be made. |
|
Looks good, thank you for fixing this @theoway 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16
This PR initiates the idea to add this check across appropriate places to stop retrying uploading in case of non-recoverable failure.
I'll also make a PR at NodeODM so that
noRetry: Trueis returned when NodeODM runs into a non-recoverable error