Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address // TODO: replace with cetl::span<IMedia*> #349

Closed
serges147 opened this issue Apr 22, 2024 · 0 comments · Fixed by #354
Closed

Address // TODO: replace with cetl::span<IMedia*> #349

serges147 opened this issue Apr 22, 2024 · 0 comments · Fixed by #354
Assignees
@serges147

Comments

@serges147
Copy link
Collaborator

  • switch to the latest CETL (where there is fix for the span)
  • address // TODO: replace with cetl::span<IMedia*>
@serges147 serges147 self-assigned this Apr 22, 2024
@serges147 serges147 mentioned this issue Apr 22, 2024
Merged
serges147 added a commit that referenced this issue Apr 22, 2024
@serges147
Fix for issue #349 #verification
7c0a538 
Addressed `// TODO: replace with cetl::span<IMedia*>`
@serges147 serges147 mentioned this issue Apr 26, 2024
Merged
@pavel-kirienko pavel-kirienko linked a pull request Apr 29, 2024 that will close this issue
CAN Msg TX Session implementation #354
Merged
thirtytwobits pushed a commit that referenced this issue May 1, 2024
@serges147 @sshirokov-mwb
CAN Msg TX Session implementation (#354)
ab7627e 
- Implemented TX behavior:
- building contiguous payload from TX fragments (see internal
`ContiguousPayload`)
  - pushing the payload to each media canard TX queue
- `can::TransportImpl::run` now peeks, pushes to media, and finally pops
TX queue items (see `runMediaTransmit`)
  - implemented dropping of expired transfers
- implemented flushing of TX queues on transport destruction - no memory
leaks now in case there were not transmitted queue items
  - extended `ITransport` with new `setLocalNodeId` method
- A bit simplified creation of RX session (b/c it turns out that there
is no failure path; but assert is there just in case)
- Addressed issue #349 
- More documentation
- Previous PR fixes:
  - `memcpy` → `memmove`
  - removed not needed `inline`-s
  - `std::` prefixes before std integrals

Also:
- better coverage stats for branches
- no doxygen warnings
- fixed some places where `noexcept` were lost
- `override` → `final` where applicable (for Scott ;) )

Coverage:
<img width="1680" alt="image"
src="https://github.com/OpenCyphal-Garage/libcyphal/assets/2915466/ebc795a9-72a4-4da8-a049-adb899d09480">

---------

Co-authored-by: Sergei Shirokov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@serges147 serges147

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CAN Msg TX Session implementation OpenCyphal-Garage/libcyphal
2 participants
@serges147 @pavel-kirienko