Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite loop in the AVL tree #254

Closed
pavel-kirienko opened this issue Jun 24, 2019 · 5 comments
Closed

Infinite loop in the AVL tree #254

pavel-kirienko opened this issue Jun 24, 2019 · 5 comments
Assignees

Comments

@pavel-kirienko
Copy link
Member

It has been reported that there is allegedly an infinite loop in the AVL tree:

https://forum.uavcan.org/t/libuavcan-cubemx-freertos-systemworkbenchforstm32/430/9?u=pavel.kirienko

@dpslwk
Copy link

dpslwk commented Jul 16, 2019

fix suggested by kolos450 in the linked thread got this working for me on an STM32L433 under FreeRTOS

@pavel-kirienko
Copy link
Member Author

For reference, this is the suggested fix copy-pasted from the forum verbatim:

Hi. I've got the same issue. There is a typo in the appendToEndOf method:

target = head->equal_keys;

should be

target = target->equal_keys;

The case happens when the driver is busy and all the frames produced from a single message are sent to a linked list.

@thirtytwobits should we just go ahead and fix this, seeing as @Zarkopafilis is unavailable?

@pavel-kirienko
Copy link
Member Author

@thirtytwobits
Copy link
Contributor

I'll take a look

@thirtytwobits
Copy link
Contributor

All fixed. Thanks for the bug report and sorry for the slow response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants