Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework CloPos and add tests #5

Conversation

CursedFlames
Copy link
Member

This PR replaces the long packing of CloPos in such a way that chunk positions pack the same way as when using ChunkPos.toLong, for compatibility reasons.

Copy link
Member

@NotStirred NotStirred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally all good, as discussed in discord:

  • perhaps add javadoc of a concrete example of invalid Clo, a cube and a chunk, explaining why
  • asLong should probably use the asLong static methods internally

This commit replaces the long packing of CloPos in such a way that chunk positions pack the same way as when using ChunkPos.toLong, for compatibility reasons.
@CursedFlames CursedFlames force-pushed the MC_1.20_neoforge_clopos_redesign branch from 56b13e3 to 6406100 Compare January 9, 2024 06:33
@NotStirred NotStirred merged commit 4d81308 into OpenCubicChunks:MC_1.20_neoforge Jan 9, 2024
1 check passed
@CursedFlames CursedFlames deleted the MC_1.20_neoforge_clopos_redesign branch January 15, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants